This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
ci: LEAP-753: E2E image problems #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlomzik
force-pushed
the
ci-leap-753/e2e-image-problems
branch
from
8526a80 to
9d0b9f9
Compare
hlomzik
added a commit
that referenced
this pull request
Feb 25, 2024
14 tasks
hlomzik
added a commit
that referenced
this pull request
Feb 26, 2024
* fix: LEAP-740: Don't use destroy = null There are external places that can call destroy unconditionally, so having it uninitialized is dangerous and leads to app crash. * Fail E2E test if Image is not loaded * Revert destroy() behavior to original one * Trigger CI * Skip failing tests for now (until #1708)
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
* fix: LEAP-740: Don't use destroy = null There are external places that can call destroy unconditionally, so having it uninitialized is dangerous and leads to app crash. * Fail E2E test if Image is not loaded * Revert destroy() behavior to original one * Trigger CI * Skip failing tests for now (until HumanSignal#1708)
- Calculate natural image size to calculate a real zoom on init (~1.05) - Remove unnecessary waits, especially the one for 10(!) seconds - Enable DEV-3377 FF to fix region shift on zoom - Enable DEV-3793 FF to use relative coords for proper calculations - Fix the way FF applied — they should be set before the `I.amOnPage()` - Precision is increased to 2 (lower precisions result in rounding errors) - Added comments to understand the flow of the test and exact calculations
jombooth
reviewed
Mar 4, 2024
Comment on lines
+263
to
+264
| // ...relatively to displayed image size, which is canvas size when we open the page |
There was a problem hiding this comment.
really helpful comments here and below, nice
jombooth
approved these changes
Mar 4, 2024
Gondragos
approved these changes
Mar 5, 2024
hlomzik
added a commit
to HumanSignal/label-studio
that referenced
this pull request
Mar 26, 2024
- HumanSignal/label-studio-frontend#1192 for Magic Wand from @BradNeuberg - HumanSignal/label-studio-frontend#1708 with external images problem - HumanSignal/label-studio-frontend#1021 for maxUsages missed for some reason
7 tasks
hlomzik
added a commit
to HumanSignal/label-studio
that referenced
this pull request
Mar 27, 2024
* feat: LEAP-219: Update LSF E2E with recent changes - HumanSignal/label-studio-frontend#1192 for Magic Wand from @BradNeuberg - HumanSignal/label-studio-frontend#1708 with external images problem - HumanSignal/label-studio-frontend#1021 for maxUsages missed for some reason * Fix newlines in all LSF E2E from CRLF to LF * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8429166524 * Update web/libs/editor/tests/e2e/tests/ner-text.test.js * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8429666577 --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: bmartel <brandonmartel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for E2E tests. Main thing is to use less 3rd-party images in tests, so one specific image was replaced and all tests affected had to be adjusted because of new dimensions. Important other changes:
It's better to check the diff with whitespace changes hidden.
PR fulfills these requirements
Describe the reason for change
4 tests started to fail because one image from
user.fmdomain became unreacheable, so we had to disable them in #1706. In general it's dangerous to rely on 3rd party resources, so we had to switch to images hosted on our premises.What alternative approaches were there?
Leave those tests disabled, but that's not a good way to go, especially for image tests, they are important.
What level of testing was included in the change?