-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Configurator.FormatterFactories public #150
Comments
Good idea. This is rather related to localisation suggestion in #105. |
Some more thoughts:
I think we should tackle this whole thing in one hit. THoughts? |
I'd agree, adding / removing formatters, ordinalizers, and converters is definitely configuration so it makes sense to expose that all through Configurator. It seems like the next thing to handle with these would be #218 and making the factories lazy by default. I'll see if I can spend a little time this evening and get a nice solution that'll take care of both issues one go without cluttering up Configurator too much. |
Thanks @justin-edwards |
Fixed in #243 |
I suggest to make
Configurator.FormatterFactories
public or add methods to add and remove factories from configuration. It can be useful if someone wants to use custom formatter which is, for example, not ready to be included to a library, etc.The text was updated successfully, but these errors were encountered: