Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nerd-sniped myself this morning:
CurrentCultureIgnoreCase
in the presence of anIFormatProvider
. Since mostIFormatProviders
areCultureInfo
, we can use theirCompareInfo
.str.IndexOf(...) == 0
which can be more efficiently written asstr.StartsWith(...)
.Checklist
Here is a checklist you should tick through before submitting a pull request:
CurrentCultureIgnoreCase
change? Existing tests pass.If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attributionXml documentation is added/updated for the addition/changedev
branch (more info below)Link to the issue(s) you're fixing from your PR description. Usefixes #<the issue number>
Readme is updated if you change an existing feature or add a new onebuild.cmd
orbuild.ps1
and ensure there are no test failures