Made Dutch (NL) localization a neutral culture, not just for Belgium #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good addition, this is called a neutral culture. |
ErikSchierboom
changed the title
|
Cool. Thanks for this. I don't know how this got in without tests in the first place. So I am going to ask you to kindly add some unit tests for it first!! To implement unit tests you might check out unit tests for one of the other cultures. |
|
@MehdiK But of course. I have added the tests. |
|
I love it that you also added TimeSpan resources :) |
MehdiK
added a commit
that referenced
this pull request
Mar 28, 2014
Made Dutch (NL) localization a neutral culture, not just for Belgium
MehdiK
added a commit
that referenced
this pull request
Mar 28, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, there is a Dutch localization file but it is targeted specifically to Belgian Dutch. However, all the localized strings are also valid Netherlands Dutch. So I have renamed the
Resources.nl-BE.resxfile to the more generalResources.nl.resx.