-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'toes' being singularized to 'to' #1136
Conversation
@hazzik I reviewed my original change and noticed that the singularization bug would also affect other words with only one char leading before "oe"/"oes" (ie. "doe"/"does" or "woe"/"woes"). I changed the rule accordingly. |
What about |
😲 That looks complicated. Do we have any rule about nouns with more than one meaning and different inflection rules? |
Looks like this needs to be rebased after one of the other PR's merged. |
Yes, I anticipated it, but wasn't sure which would be merged first. Rebase done. 🙂 |
Is this ready to go? |
Fixes #1100
Here is a checklist you should tick through before submitting a pull request:
dev
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failures