Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format String #117

Merged
merged 3 commits into from
Mar 30, 2014
Merged

Format String #117

merged 3 commits into from
Mar 30, 2014

Conversation

wahidshalaly
Copy link
Contributor

Added unit tests for StringExtensions & updated readme.md

@MehdiK
Copy link
Member

MehdiK commented Mar 30, 2014

Your PR is behind with a few commits. Please pull, rebase and force-push.

@MehdiK
Copy link
Member

MehdiK commented Mar 30, 2014

Actually don't worry about this. I will do it.

@MehdiK MehdiK merged commit df7092c into Humanizr:master Mar 30, 2014
@wahidshalaly
Copy link
Contributor Author

Something wrong with the #format anchor in readme.md !!

@MehdiK
Copy link
Member

MehdiK commented Mar 30, 2014

hahaha, yeah that caught me when I was adding Table of Contents. GitHub overrides your anchor ids based on the anchor text!!! Fixing that right now. Don't worry :)

Thanks a lot for adding the tests and the readme bit (and rebasing). Great work.

@MehdiK
Copy link
Member

MehdiK commented Mar 30, 2014

Fixed now. Also moved String extensions to the top for better grouping. May have to revisit the Table of Contents later and reorganize it a bit later with similar features in closer vicinity.

@wahidshalaly wahidshalaly deleted the string_extensions branch March 30, 2014 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants