-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Luxembourgish localisation #1256
Add Luxembourgish localisation #1256
Conversation
This PR includes Luxembourgish localisation based on a mix of implementations for different languages (i.e. German, French, Icelandic, ...). The most annoying part is dealing with the `Eifeler Regel`, where an `n` must be removed from a word based on a number of factors (punctuation, location within sentence, and most importantly, the first letter of the following word).
Hey 👋🏼 @clairernovotny @hazzik I would like to integrate Humanizer into our internal tools, it would be ideal to have Luxembourgish included when I do (we usually support the 4 major languages, English, French, German, and Luxembourgish). Would you be able to provide me with a very approximate ETA on if/when this could be merged and released? I'm not in a major rush -- just seeing as the last release dates back a year I'd like to have an idea of whether I should look into publishing something privately for our use-case 😉 |
@igotinfected can you rebase |
Done! Struggling with some Big thanks to you and everyone involved for reviving the project :) |
thanks
yeah i have not worked out the cause of those. and not related to your changes |
This PR includes Luxembourgish localisation based on a mix of implementations for different languages (i.e. German, French, Icelandic, ...). The most annoying part is dealing with the
Eifeler Regel
, where ann
must be removed from a word based on a number of factors (punctuation, location within sentence, and most importantly, the first letter of the following word).Here is a checklist you should tick through before submitting a pull request:
main
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failures