Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Luxembourgish localisation #1256

Merged

Conversation

igotinfected
Copy link
Contributor

This PR includes Luxembourgish localisation based on a mix of implementations for different languages (i.e. German, French, Icelandic, ...). The most annoying part is dealing with the Eifeler Regel, where an n must be removed from a word based on a number of factors (punctuation, location within sentence, and most importantly, the first letter of the following word).

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

This PR includes Luxembourgish localisation based on a mix of
implementations for different languages (i.e. German, French, Icelandic,
...). The most annoying part is dealing with the `Eifeler Regel`, where
an `n` must be removed from a word based on a number of factors
(punctuation, location within sentence, and most importantly, the first
letter of the following word).
@igotinfected
Copy link
Contributor Author

Hey 👋🏼 @clairernovotny @hazzik

I would like to integrate Humanizer into our internal tools, it would be ideal to have Luxembourgish included when I do (we usually support the 4 major languages, English, French, German, and Luxembourgish). Would you be able to provide me with a very approximate ETA on if/when this could be merged and released? I'm not in a major rush -- just seeing as the last release dates back a year I'd like to have an idea of whether I should look into publishing something privately for our use-case 😉

@SimonCropp
Copy link
Collaborator

@igotinfected can you rebase

@igotinfected
Copy link
Contributor Author

@igotinfected can you rebase

Done! Struggling with some Fr and He tests failing locally randomly, don't think it's related to my changes though.

Big thanks to you and everyone involved for reviving the project :)

@SimonCropp
Copy link
Collaborator

thanks

Struggling with some Fr and He tests failing locally randomly

yeah i have not worked out the cause of those. and not related to your changes

@SimonCropp SimonCropp added this to the v3.0 milestone Feb 14, 2024
@SimonCropp SimonCropp merged commit 6cb496a into Humanizr:main Feb 15, 2024
3 checks passed
@igotinfected igotinfected deleted the feature/add-luxembourgish-localisation branch February 15, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants