Danish translation #144
Closed
Danish translation #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [InlineData(1299630020, 3, "2 weeks, 1 dag, 1 time")] | ||
| [InlineData(1299630020, 4, "2 weeks, 1 dag, 1 time, 30 sekunder")] | ||
| [InlineData(1299630020, 5, "2 weeks, 1 dag, 1 time, 30 sekunder, 20 millisekunder")] | ||
| public void TimeSpanWithPrecesion(int milliseconds, int precesion, string expected) |
There was a problem hiding this comment.
This isn't necessary here. In the main implementation I had to make sure that precisions work but once that's proven and you test your translations, the rest is just the implementation stitching the two together. So please remove this. Thanks.
|
Thanks for the contribution. I've added some comments to your code. Also it seems like some of your tests are red. |
|
Made the changes you commented on. Was to trigger happy with the pull request, so forgot to run the tests. |
|
Thanks for the fixes. Merged now. |
Was using the wrong language code and fixed some spelling errors. Changes text in TimeSpanWithPrecesion test.
|
Thanks for your great contribution. This is now released to NuGet as v1.19.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added danish translation + tests.