Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spanish FromNow strings #146

Closed
wants to merge 3 commits into from

Conversation

thunsaker
Copy link
Contributor

Updated the FromNow strings which were absent from the default Spanish (es) resource strings.

@thunsaker
Copy link
Contributor Author

FYI: Spanish ToWords is in the wings, I'll submit another PR when ready.

{
Assert.Equal(expected, DateTime.UtcNow.AddDays(days).Humanize());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replacing these! :)

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Cool. ToWords addition would be really nice.

@thunsaker
Copy link
Contributor Author

See #151 :)

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Just saw it. Thanks :) 25 Humanizer related emails in the inbox. Catching up slowly :)

@thunsaker
Copy link
Contributor Author

@MehdiK these changes are ready to go...they seemed to be outside the scope of recent changes. Unless you'd like me to close this and #151 and put together another PR with ALL of the Spanish translations.

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Merged now

@MehdiK MehdiK closed this Apr 10, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Thanks for your great contribution. This is now released to NuGet as v1.19.1.

@thunsaker thunsaker deleted the spanish-string-updates branch April 10, 2014 18:10
@thunsaker
Copy link
Contributor Author

@MehdiK Awesome! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants