Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "ناقص" with "سالب" for negative number representation in Arabic #1539

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace "ناقص" with "سالب" for negative number representation in Arabic #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91c26fb
Replace "ناقص" with "سالب" for negative number representation in Arabic
omarjkf Sep 6, 2024
5591477
Replace "ناقص" with "سالب" for testing
omarjkf Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/Humanizer.Tests/Localisation/ar/NumberToWordsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ public void ToWordsArabic(string expected, int number) =>
Assert.Equal(expected, number.ToWords());

[Theory]
[InlineData("ناقص واحد", -1)]
[InlineData("ناقص اثنان", -2)]
[InlineData("ناقص اثنان و عشرون", -22)]
[InlineData("ناقص أحد عشر", -11)]
[InlineData("ناقص ثلاثة آلاف و خمس مئة و واحد", -3501)]
[InlineData("ناقص مليون و واحد", -1000001)]
[InlineData("سالب واحد", -1)]
[InlineData("سالب اثنان", -2)]
[InlineData("سالب اثنان و عشرون", -22)]
[InlineData("سالب أحد عشر", -11)]
[InlineData("سالب ثلاثة آلاف و خمس مئة و واحد", -3501)]
[InlineData("سالب مليون و واحد", -1000001)]
public void ToWordsArabicNegative(string expected, int number) =>
Assert.Equal(expected, number.ToWords());

Expand All @@ -46,8 +46,8 @@ public void ToWordsArabicNegative(string expected, int number) =>
[InlineData(1111111111111111111L, "كوينتليون و مئة و أحد عشر كوادريليوناً و مئة و أحد عشر تريليوناً و مئة و أحد عشر ملياراً و مئة و أحد عشر مليوناً و مئة و أحد عشر ألفاً و مئة و أحد عشر")]
[InlineData(10000000001L, "عشرة مليارات و واحد")]
[InlineData(8750000500001L, "ثمانية تريليونات و سبع مئة و خمسون ملياراً و خمس مئة ألفاً و واحد")]
[InlineData(-10000000001L, "ناقص عشرة مليارات و واحد")]
[InlineData(-8750000500001L, "ناقص ثمانية تريليونات و سبع مئة و خمسون ملياراً و خمس مئة ألفاً و واحد")]
[InlineData(-10000000001L, "سالب عشرة مليارات و واحد")]
[InlineData(-8750000500001L, "سالب ثمانية تريليونات و سبع مئة و خمسون ملياراً و خمس مئة ألفاً و واحد")]
public void ToWordsArabicLong(long number, string expected) =>
Assert.Equal(expected, number.ToWords());

Expand Down Expand Up @@ -178,4 +178,4 @@ public void ToOrdinalWords(int number, string words) =>
[InlineData(1020135, "الخامسة و الثلاثون بعد المليون و عشرون ألفاً و مئة")]
public void ToOrdinalWordsWithFeminineGender(int number, string words) =>
Assert.Equal(words, number.ToOrdinalWords(GrammaticalGender.Feminine));
}
}
4 changes: 2 additions & 2 deletions src/Humanizer/Localisation/NumberToWords/ArabicNumberToWordsConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public override string Convert(long number, GrammaticalGender gender, bool addAn

if (number < 0)
{
return $"ناقص {Convert(-number, gender)}";
return $"سالب {Convert(-number, gender)}";
}

var result = string.Empty;
Expand Down Expand Up @@ -310,4 +310,4 @@ static string ParseNumber(string word, int number, GrammaticalGender gender)

return word;
}
}
}