-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Dutch numbers to words support #166
Conversation
{ | ||
public class NumberToOrdinalWordsTests : AmbientCulture | ||
{ | ||
public NumberToOrdinalWordsTests() : base("nl-NL") { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some weird spacing issues throughout the code! Please reformat your code.
There are 10 failing unit tests. Please fix these. Also please add your PR to the release-notes file. |
Wow, how did that happen?! I'll fix it shortly! // Ryan On Thu, Apr 10, 2014 at 4:50 PM, Mehdi Khalili notifications@git.luolix.topwrote:
|
Sorry. GitHub doesn't send notifications for new commits and your changes slipped under my radar. Now the whole thing has changed so much it's quite hard to rebase your changes o_O I think the easiest way would be for you to pull from upstream and apply your changes again as rebase is going to be quite painful. Sorry |
I have rebased my changes on the latest version. // Ryan On Sat, Apr 12, 2014 at 3:29 PM, Mehdi Khalili notifications@git.luolix.topwrote:
|
Splendid! Thanks a lot. |
This is now on NuGet as v1.22.1. Thanks for the contribution. |
No description provided.