Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T4 Template Fix / EnglishWordsConverter directly. #171

Merged
merged 5 commits into from
Apr 10, 2014

Conversation

anoehre
Copy link
Contributor

@anoehre anoehre commented Apr 10, 2014

Fixes #169

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Thanks a lot for the fix.

Please rebase your work on top of upstream and also add your PR to release-notes files.

@anoehre
Copy link
Contributor Author

anoehre commented Apr 10, 2014

Rebase done. Release notes are updated. What about the failing test?

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Haha, when I reviewed your code CI was still building your PR. Yeah that needs to be fixed too. Run the tests and it should pop up a diff tool showing the old approved API vs the new one. Apply your changes on the approved API (left -> right), commit and push. That should fix it.

@anoehre
Copy link
Contributor Author

anoehre commented Apr 10, 2014

Yay, all tests passed. Must check out this approval test thing, very interesting.

MehdiK added a commit that referenced this pull request Apr 10, 2014
T4 Template Fix / EnglishWordsConverter directly.
@MehdiK MehdiK merged commit 3dea90e into Humanizr:master Apr 10, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

Thanks a lot for the fix.

Yeah, ApprovalTests is really awesome. You know what else is quite awesome that you should check? TestStack :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with T4 code generation
2 participants