handle Display attribute specially #333
Merged
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,6 +34,8 @@ public class EnumTestsResources | |||
| public const string MemberWithoutDescriptionAttributeSentence = "Member without description attribute"; | |||
| public const string MemberWithoutDescriptionAttributeTitle = "Member Without Description Attribute"; | |||
| public const string MemberWithoutDescriptionAttributeLowerCase = "member without description attribute"; | |||
| public const string MemberWithDisplayAttribute = "Description from Display attribute"; | |||
| public static string MemberWithLocalizedDisplayAttribute { get { return "Localized description from Display attribute"; } } | |||
|
Thanks a lot for adding the readme bit and unit tests. Awesome PR as always. Just one minor tweak on the readme and it's good to go. |
MehdiK
added a commit
that referenced
this pull request
Sep 10, 2014
handle Display attribute specially
|
This is now released to NuGet as v1.29.0. Thanks for the great addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provides support for enum localization requested in #323