Adds Chinese localisation #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add your PR to the release-notes file (to "in development" section). See CONTRIBUTING.md. |
|
thx, I've added to the release-notes file. |
| public DateHumanizeTests() : base("zh-CHS") { } | ||
|
|
||
| [Theory] | ||
| [InlineData(-2, "2 天前")] |
There was a problem hiding this comment.
Why do we have values for -1 and 1? In fact there shouldn't be any negative test cases as they're all changed to absolute in Verify. Please remove the duplicate 1/-1s and change the negative cases to positive. Thanks
|
This is now merged. Thanks for the contribution. |
|
Thanks for the contribution. This is now available on NuGet as v1.32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Chinese localisation and fixed encoding