Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes UnitPreposition to avoid warnings in Win 8.1 apps #366

Merged
merged 1 commit into from
Dec 25, 2014

Conversation

MehdiK
Copy link
Member

@MehdiK MehdiK commented Dec 24, 2014

Alternative solution for #360 to fix warnings in #317

@MehdiK MehdiK force-pushed the removes-UnitPreposition branch from ee43d6b to 771373e Compare December 24, 2014 06:43
@MehdiK
Copy link
Member Author

MehdiK commented Dec 24, 2014

I'd appreciate a code review /cc @mexx @hazzik @pombeirp

@pedropombeiro
Copy link

@MehdiK I think this should fix that issue.

@mexx
Copy link
Collaborator

mexx commented Dec 24, 2014

@MehdiK LGTM 👍

@hazzik
Copy link
Member

hazzik commented Dec 24, 2014

LGTM

MehdiK added a commit that referenced this pull request Dec 25, 2014
Removes UnitPreposition to avoid warnings in Win 8.1 apps
@MehdiK MehdiK merged commit 49859df into master Dec 25, 2014
@MehdiK MehdiK deleted the removes-UnitPreposition branch December 25, 2014 04:16
@MehdiK
Copy link
Member Author

MehdiK commented Dec 25, 2014

Thanks for the review guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants