Break out Vocabulary/DefaultVocabulary to make Inflector more extensible.

[jkodroff]

fixes #402

[jkodroff]

@MehdiK I made this a little less ambitious than what was discussed in #402. I didn't want to solve anything that wasn't actually being asked for. The idea here is that:

1. We fixed the immediate problem of the units of measurement.
2. The user can add additional rules if necessary.

[jkodroff]

Assuming that the API difference failures are something you'll have to approve.

[mexx]

@jkodroff what is the reason why you moved this enum? Please move it back to Humanizer namespace.

[mexx]

@jkodroff First of all, thank you for the PR.

Regarding the comments:
In Humanizer we try to not break as much as possible and test through the public interface.
You've actually removed the tests for the Singularize and Pluralize inflector extensions, as stated this should be reverted.
The tests for the Vocabulary class should include tests for the new public methods like AddPlural, AddSingular, AddIrregular and AddUncountable. Actually this class is tested anyway through the indirect use from inflector extension methods, so I wouldn't necessarily test it.

Regarding the approval:
Please extend the approval file with the added methods as part of your PR.
The build (build.cmd) shouldn't fail neither on your machine nor on the server.

And also add your PR to the release notes.
Also please add documentation for added possibility of vocabulary customization.

Please see CONTRIBUTING.md for more details.

[jkodroff]

@mexx That all sounds reasonable to me. I think I should be able to find time to make those changes this week.

Thanks for your patience with this new contributor - PR's on well-documented libraries like this one are new to me.

[jkodroff]

Ugh. I'm so sorry for letting this sit so long. I'll be sure to get it
done this weekend.

On Thu, May 7, 2015 at 5:49 AM, Dmytro IELKIN notifications@github.com
wrote:

@jkodroff https://github.com/jkodroff When do you think you can fix the
tests and commit the change?

—
Reply to this email directly or view it on GitHub
#408 (comment).

[jkodroff]

@mexx Made the requested changes. We should be good now. If you want to kill this PR and have me resubmit these changes squashed as a single commit, no problem.

[mexx]

Can you please remove this default constructor from public surface?
This class isn't intended to have any instance, right?

[mexx]

@jkodroff Looks better.

You've actually removed the tests for the Singularize and Pluralize inflector extensions, as stated this should be reverted.

There were many comments from my side, I think you overlooked this one. Can you please revert the changes to InflectorTests.cs file.

[jkodroff]

@mexx Are we good now?

[MehdiK]

Thanks @jkodroff. I made a few changes, rebased your branch on top of origin and pushed up. Please have a look at the changes I made to see if you're happy with them.

[MehdiK]

Thanks for the contribution. This is now available on nuget as v1.36.0.