-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue38fix #43
Issue38fix #43
Conversation
…at passes all existing test cases - there may be others that don't pass though? Fixes #38
Nice! I like how you have made the new code "safer" by allowing people to opt-in. Very cool. |
re: inline data I'm happy to put in another PR since I think I know how to do it |
Cool. I hate the for-loop data injection for tests but also hate to repeat all those entries 2500 times! Looking forward to your PR. |
I'll do it after you merge this one to avoid conflicts |
This looks good to me - added a few minor comments |
Thanks mate. I fixed the issues you raised. |
@hazzik Although this is merged, I would still really appreciate your review and will capture your notes as issues to be resolved in future changes. |
@MehdiK looks good for me. Thanks! |
Plurality
enum to avoid redundant loops when unnecessary@robdmoore @hazzik could you please review? Thanks