Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial TimeSpan Arabic support #52

Merged
merged 2 commits into from
Jan 6, 2014
Merged

Initial TimeSpan Arabic support #52

merged 2 commits into from
Jan 6, 2014

Conversation

harouny
Copy link
Contributor

@harouny harouny commented Jan 5, 2014

This push contains initial Arabic support for humanizing (Singular) TimeSpan elements.

MehdiK added a commit that referenced this pull request Jan 6, 2014
Initial TimeSpan Arabic support
@MehdiK MehdiK merged commit ffc27ea into Humanizr:master Jan 6, 2014
@MehdiK
Copy link
Member

MehdiK commented Jan 6, 2014

Thanks @harouny for the contribution.

I would really appreciate if you could implement an Arabic formatter so the Arabic translation becomes more accurate and useful. Some tests for the DateTime humanize would be nice too. Thanks :)

@harouny
Copy link
Contributor Author

harouny commented Jan 6, 2014

You are welcome :)
Yep, an Arabic formatter is in my list of things to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants