Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding parameter decimals toMetric(). Fixes #609 #610

Merged
merged 1 commit into from
Apr 18, 2017
Merged

adding parameter decimals toMetric(). Fixes #609 #610

merged 1 commit into from
Apr 18, 2017

Conversation

klaus78
Copy link

@klaus78 klaus78 commented Jan 12, 2017

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@klaus78 klaus78 changed the title adding parameter decimals toMetric(). See issue #609 adding parameter decimals toMetric(). Fixes #609 Jan 12, 2017
@klaus78 klaus78 closed this Feb 17, 2017
@klaus78 klaus78 reopened this Feb 20, 2017
@clairernovotny clairernovotny merged commit 283b233 into Humanizr:dev Apr 18, 2017
@clairernovotny clairernovotny modified the milestone: v2.2 Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants