Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Latvian number to words converter #902

Merged
merged 8 commits into from
Sep 30, 2021

Conversation

vnsharanin
Copy link
Contributor

@vnsharanin vnsharanin commented Jan 29, 2020

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@clairernovotny
Copy link
Member

Thank you for this! Any chance you can add the date and time translations too? You can see the Properties\Resources resx files to see what needs to be done?

@hazzik hazzik changed the title Features/add lv Add Latvian number to words converter May 30, 2021
@vnsharanin
Copy link
Contributor Author

vnsharanin commented Sep 30, 2021

Hello @clairernovotny I'm sorry, I tried to do it, but I think that will be better if translations for date and time can do somebody else. But by the way I see that TimeSpanHumanizeTests already was added in here 7f85134
Could we merge this PR please?

@clairernovotny clairernovotny merged commit 2a4c964 into Humanizr:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants