Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeSpan-related humanization for French culture #974

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

louis-z
Copy link
Contributor

@louis-z louis-z commented Sep 6, 2020

Fixes #973

  • Replace "année" with "an"
  • Make sure 0 is followed by a singular time unit (not plural, as in English)
  • Replace "pas de temps" by "temps nul", which arguably sounds more natural

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

- Replace "année" with "an"
- Make sure 0 is followed by a singular time unit (not plural, as in English)
- Replace "pas de temps" by "temps nul", which arguably sounds more natural
@clairernovotny clairernovotny merged commit 3fe8b75 into Humanizr:master Sep 26, 2020
@clairernovotny
Copy link
Member

Thanks!

@louis-z louis-z deleted the issue-973 branch September 26, 2020 17:25
@louis-z
Copy link
Contributor Author

louis-z commented Sep 26, 2020

You're welcome. Glad I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeSpan-related humanization with French culture is inconsistent
2 participants