Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included workaround for error 'Image given has not completed loading'... #39

Closed
wants to merge 1 commit into from

Conversation

Brootux
Copy link

@Brootux Brootux commented Jul 28, 2014

... of canvas-library. The error was happening when working with lots of images to compare.

Found workaround here: Automattic/node-canvas#254

Comparing now works for me. Hope this helps anybody.

@cburgmer
Copy link
Contributor

Thanks. Also see #17, #31 and #35.

@Brootux
Copy link
Author

Brootux commented Jul 30, 2014

Ill never tried this via comandline. Im using the node-module "grunt-screenshot-compare" wich uses "automated-screenshot-diff" wich in the end uses "js-imagediff".

I have no ressources to check if this solves all other use-cases, so maybe we should wait until other people patched their js-imagediff and give a positive response?

@cesutherland
Copy link
Member

In the cases where the "Image given has not completed loading" the image data will be computed and returned before the image has been drawn.

@cesutherland
Copy link
Member

This should be all sorted with the merge of #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants