CPU table optimisation (#21)

* changed instruction switch statement into a function table, some minor changes to the cb_table function which unnecessarily converted indexes to bytes * variable scope bug fix for densifying the main instruction table * fixed comments, removed ExecuteOpcode method, moved table creation to instructions.go, and minor style changes
Humpheh · Nov 27, 2018 · f876370 · f876370
1 parent c35240e
commit f876370
Show file tree

Hide file tree

Showing 3 changed files with 1,224 additions and 1,215 deletions.
diff --git a/pkg/gb/gameboy.go b/pkg/gb/gameboy.go
@@ -46,7 +46,8 @@ type Gameboy struct {
 	interruptsOn       bool
 	halted             bool
 
-	cbInst    []func()
+	mainInst  [0x100]func()
+	cbInst    [0x100]func()
 	InputMask byte
 
 	// Flag if the game is running in cgb mode. For this to be true the game
@@ -314,6 +315,7 @@ func (gb *Gameboy) setup() {
 	gb.scanlineCounter = 456
 	gb.InputMask = 0xFF
 
+	gb.mainInst = gb.mainInstructions()
 	gb.cbInst = gb.cbInstructions()
 
 	gb.SpritePalette = NewPalette()