Fixed a bug with the intro #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you choose a more descriptive commit title please? A title containing only the word "fixed" doesn't really say anything about what the commit does. |
added check for IntroStateEnum::DONE
Mia75owo
force-pushed
the
fix-intro-bug
branch
from
b44d8c7
to
16cff7e
Compare
|
Verified, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug:
The intro has a counter which is used to fade it out when a key is pressed.
When the counter reaches 0 the intro state gets changed to DONE.
When a key is still pressed, the function EndIntro will be called and it checks if the
intro state is not FADEOUT, but not for DONE, so it will restart the fade out sequence.
To repoduce this just hold a key pressed when ending the intro, as long as the key is pressed
the intro will always restart the fading.