Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

298 add missing commands for the vested staking #83

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

Vitomir2
Copy link
Contributor

@Vitomir2 Vitomir2 commented Nov 29, 2024

Description

  • update the bindings to include the stakeWithVesting and getValidator;
  • add new flags - vesting and vesting-period, and verify the period to e in the valid period;
  • create a new createStakeTransaction function in order to make the code more readable and cleaner;
  • optimize the code in the logs loop;
  • make the amount flag mandatory;
  • mark flags mutually exclusive with the delegate flag;
  • make a MaxVestingPeriod constant in the sidechain helper;
  • fix the conditions in the commission command event handling;
  • rename stakeManager -> hydraStaking in the register_validator to avoid confusion;
  • create ValidatorStatus enum and GetStatus function in the validator package;
  • create a new getValidatorInfo helper function to get the data that I need;
  • update docs;

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

update the bindings to include the stakeWithVesting;
add new flags - vesting and vesting-period, and verify the period to e in the valid period;
create a new createStakeTransaction function in order to make the code more readable and cleaner;
optimize the code in the logs loop;
make the amount flag mandatory;
mark flags mutually exclusive with the delegate flag;
make MaxVestingPeriod constant in the sidechain helper;
fix the conditions in the commission command event handling;
rename stakeManager -> hydraStaking in the register_validator to avoid confusion;
update the bindings to contain the getValidator function from the HydraChain contract;
create a new getValidatorInfo helper function to get the data that I need;
update docs;
@Vitomir2 Vitomir2 added the enhancement New feature or request label Nov 29, 2024
@Vitomir2 Vitomir2 marked this pull request as ready for review November 29, 2024 12:09
README.md Outdated Show resolved Hide resolved
command/sidechain/staking/params.go Outdated Show resolved Hide resolved
consensus/polybft/validator/validator_metadata.go Outdated Show resolved Hide resolved
Vitomir2 and others added 2 commits December 2, 2024 17:07
Co-authored-by: Rosen Santev <77731162+R-Santev@users.noreply.github.com>
move the ValidatorStatus and the GetStatus inside the sidechain helper;
remove the vesting flag and use only the vesting-period;
update the readme;
@Vitomir2 Vitomir2 merged commit 02f0619 into develop Dec 2, 2024
5 checks passed
@Vitomir2 Vitomir2 deleted the 298-add-missing-commands-for-the-vested-staking branch December 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants