-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
298 add missing commands for the vested staking #83
Merged
Vitomir2
merged 9 commits into
develop
from
298-add-missing-commands-for-the-vested-staking
Dec 2, 2024
Merged
298 add missing commands for the vested staking #83
Vitomir2
merged 9 commits into
develop
from
298-add-missing-commands-for-the-vested-staking
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the bindings to include the stakeWithVesting; add new flags - vesting and vesting-period, and verify the period to e in the valid period; create a new createStakeTransaction function in order to make the code more readable and cleaner; optimize the code in the logs loop; make the amount flag mandatory; mark flags mutually exclusive with the delegate flag; make MaxVestingPeriod constant in the sidechain helper;
fix the conditions in the commission command event handling; rename stakeManager -> hydraStaking in the register_validator to avoid confusion; update the bindings to contain the getValidator function from the HydraChain contract; create a new getValidatorInfo helper function to get the data that I need; update docs;
R-Santev
requested changes
Dec 2, 2024
Co-authored-by: Rosen Santev <77731162+R-Santev@users.noreply.github.com>
move the ValidatorStatus and the GetStatus inside the sidechain helper; remove the vesting flag and use only the vesting-period; update the readme;
R-Santev
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes include
Checklist
Testing