Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix save plan to file code. #31

Merged
merged 1 commit into from
Mar 8, 2021
Merged

fix: fix save plan to file code. #31

merged 1 commit into from
Mar 8, 2021

Conversation

edwinf
Copy link
Contributor

@edwinf edwinf commented Mar 8, 2021

Fixes an issue where the default value of empty string is being use (so undefined check fails) as well as the fact that the promise of the create dictionary is not being awaited.

@edwinf edwinf requested a review from williamwilson March 8, 2021 14:04
@edwinf edwinf merged commit bea4818 into main Mar 8, 2021
@edwinf edwinf deleted the fix-incorrect-check branch March 8, 2021 14:34
github-actions bot pushed a commit that referenced this pull request Mar 8, 2021
## [1.1.8](v1.1.7...v1.1.8) (2021-03-08)

### Bug Fixes

* fix save plan to file code. ([#31](#31)) ([bea4818](bea4818))
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

🎉 This PR is included in version 1.1.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants