Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart contract merge #26

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

smart contract merge #26

wants to merge 11 commits into from

Conversation

alexture
Copy link
Collaborator

Merged « anatomy of a smart contract » and « smart contract ABI » as they had a lot of duplicate information; corrected outdated information.

@alexture alexture requested a review from wraitii December 18, 2024 09:26

Hylé introduces **timeouts** for blob transactions to ensure timely proof submissions.

Transactions without proofs within a specific duration, as well as transactions with invalid proofs, are rejected.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense cette section mérite un peu plus de détail. Il est pas clair pourquoi c'est un problème en particulier: c'est un problème car ça délaie la finalité: dois-je inclure cette transaction dans mon state?

En soit, "transactions with invalid proofs" c'est un cas particulier un peu weird - on rejette juste les Blobs TX qui n'ont pas de valid proof dans les temps.

Par ailleurs je formulerai plus explicitement que "rejette" signifie que la transaction doit être ignorée, pas qu'elle ne fait plus partie du block


## Smart contract ABI

All inputs in Hylé smart contracts must be known at proof generation time. This includes elements that wouldn't be known on other blockchains, such as the origin of the transaction (tx.origin) and the block number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mh la phrase est un peu weird/inaccurate je trouve. Par essence, il faut tout connaitre at proof time. On connait at proof time les mêmes data qu'on aurait sur les autres chaines at execution time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentative

Suggested change
All inputs in Hylé smart contracts must be known at proof generation time. This includes elements that wouldn't be known on other blockchains, such as the origin of the transaction (tx.origin) and the block number.
All inputs in Hylé smart contracts must be known at proof generation time. This includes elements that would be known at execution time on other blockchains, such as the origin of the transaction (tx.origin) and the block number.

@alexture alexture requested a review from wraitii December 18, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants