Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Wait until the genesis block has been processed to start the consensus #616

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

wraitii
Copy link
Member

@wraitii wraitii commented Jan 14, 2025

No description provided.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/consensus.rs 38.46% 8 Missing ⚠️
src/single_node_consensus.rs 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/client-sdk/src/lib.rs 80.51% <100.00%> (+3.95%) ⬆️
src/data_availability.rs 80.85% <ø> (ø)
src/genesis.rs 94.58% <100.00%> (+0.01%) ⬆️
src/indexer.rs 73.74% <ø> (ø)
src/indexer/contract_state_indexer.rs 78.82% <ø> (ø)
src/indexer/da_listener.rs 31.32% <ø> (ø)
src/mempool.rs 80.33% <ø> (ø)
src/model.rs 72.22% <ø> (-2.07%) ⬇️
src/node_state/module.rs 64.28% <ø> (ø)
src/p2p.rs 23.47% <ø> (ø)
... and 8 more

... and 2 files with indirect coverage changes

@wraitii wraitii force-pushed the fix/consensus_waits_for_genesis branch from 1ab0863 to 8712cf9 Compare January 14, 2025 15:23
@@ -823,6 +822,20 @@ impl Consensus {
self.bft_round_state.consensus_proposal.round_leader
);
}
// Now wait until we have processed the genesis block to update our Staking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ModuleShutdownCeption

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouais j'avais vraiment l'impression de faire un truc illégal haha

@wraitii wraitii force-pushed the fix/consensus_waits_for_genesis branch from 8712cf9 to 49bd39b Compare January 15, 2025 16:40
@wraitii wraitii merged commit 0cec30e into main Jan 15, 2025
11 checks passed
@wraitii wraitii deleted the fix/consensus_waits_for_genesis branch January 15, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants