⚡️ Faster contract execution in genesis by not running in r0vm #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BertrandD
reviewed
Jan 14, 2025
| .try_into() | ||
| .expect("Failed to decode state"); | ||
|
|
||
| let _ = stdout.write_str("Init token contract"); |
There was a problem hiding this comment.
this function doesn't seem to match the guest 🤔
wraitii
force-pushed
the
feat/faster_contract_execution
branch
from
0a4e9ab to
cc48de3
Compare
wraitii
force-pushed
the
feat/faster_contract_execution
branch
2 times, most recently
from
3d7d06a to
0b857ca
Compare
maxgttph
approved these changes
Jan 16, 2025
| @@ -175,6 +179,32 @@ impl TryFrom<sdk::StateDigest> for HyllarToken { | |||
| } | |||
| } | |||
|
|
|||
| pub fn execute(stdout: &mut impl std::fmt::Write, contract_input: ContractInput) -> HyleOutput { | |||
There was a problem hiding this comment.
pourquoi pas mettre cette fonction directement dans HyllarPseudoExecutor (qu'on renommerait alors HyllarExecutor) ?
|
|
||
| #[derive(Default)] | ||
| pub struct TxExecutor<S: StateUpdater> { | ||
| full_states: S, |
There was a problem hiding this comment.
Je trouve le nom un peu ambiguë
J"aurais appelé ça all_states, ou qulque chose qui laisse ententre que c'est le state de chaque contract dans la Tx
Le mot full donne l'impression que c'est poru dire 'state complet' imo
There was a problem hiding this comment.
On vient d'en parler à l'oral :
Le typage des variables est confusing; il faut faire la distinction State (: Digestable) et StateDigest (et adapter les noms de variables en conséquence :p
BertrandD
approved these changes
Jan 16, 2025
wraitii
force-pushed
the
feat/faster_contract_execution
branch
from
0b857ca to
adcf973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.