Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Remove hyrun usage from tests #637

Merged
merged 6 commits into from
Jan 17, 2025
Merged

♻️ Remove hyrun usage from tests #637

merged 6 commits into from
Jan 17, 2025

Conversation

wraitii
Copy link
Member

@wraitii wraitii commented Jan 17, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.16949% with 159 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/contracts/amm/src/client.rs 0.00% 86 Missing ⚠️
crates/contracts/amm/src/lib.rs 0.00% 35 Missing ⚠️
crates/contracts/hyllar/src/client.rs 0.00% 33 Missing ⚠️
crates/client-sdk/src/transaction_builder.rs 76.19% 5 Missing ⚠️
Files with missing lines Coverage Δ
crates/client-sdk/src/helpers.rs 5.68% <ø> (ø)
crates/contract-sdk/src/guest.rs 38.29% <ø> (ø)
crates/contract-sdk/src/lib.rs 51.80% <ø> (ø)
crates/contracts/hydentity/src/lib.rs 98.94% <100.00%> (+0.01%) ⬆️
crates/hyle-loadtest/src/lib.rs 0.00% <ø> (ø)
src/genesis.rs 94.97% <ø> (+0.15%) ⬆️
crates/client-sdk/src/transaction_builder.rs 87.02% <76.19%> (-1.39%) ⬇️
crates/contracts/hyllar/src/client.rs 46.77% <0.00%> (-53.23%) ⬇️
crates/contracts/amm/src/lib.rs 88.42% <0.00%> (-5.05%) ⬇️
crates/contracts/amm/src/client.rs 0.00% <0.00%> (ø)

Base automatically changed from feat/faster_contract_execution to main January 17, 2025 12:43
@wraitii wraitii force-pushed the chore/remove_hyrun branch 3 times, most recently from b3e6657 to c6debb3 Compare January 17, 2025 14:06
BertrandD
BertrandD approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@BertrandD BertrandD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/contracts/amm/src/client.rs Outdated Show resolved Hide resolved
crates/contracts/amm/Cargo.toml Outdated Show resolved Hide resolved
crates/contracts/risc0-recursion/tests/recursion.rs Outdated Show resolved Hide resolved
@wraitii wraitii force-pushed the chore/remove_hyrun branch from 1bd2391 to 67f440f Compare January 17, 2025 16:25
@wraitii wraitii merged commit 2a192dd into main Jan 17, 2025
7 checks passed
@wraitii wraitii deleted the chore/remove_hyrun branch January 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BertrandD BertrandD BertrandD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wraitii @BertrandD