Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Tweak node state handling of failing (native) proofs #644

Merged
merged 1 commit into from
Jan 21, 2025
Merged

🐛 Tweak node state handling of failing (native) proofs #644

merged 1 commit into from
Jan 21, 2025

Conversation

wraitii
Copy link
Member

@wraitii wraitii commented Jan 20, 2025

No description provided.

@wraitii wraitii force-pushed the fix/nodestate_bad_proof branch 3 times, most recently from 2480b43 to c1d99ad Compare January 20, 2025 17:31
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/mempool/verifiers.rs 86.66% 4 Missing ⚠️
src/node_state.rs 83.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/node_state.rs 94.71% <83.33%> (+1.22%) ⬆️
src/mempool/verifiers.rs 57.35% <86.66%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

@wraitii wraitii force-pushed the fix/nodestate_bad_proof branch from c1d99ad to 58c1bc7 Compare January 21, 2025 09:12
maxgttph
maxgttph approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@maxgttph maxgttph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que lors de handle_signed_block on peut directement mettre la BlobTx dans failed_txs si le native verifier fail

@wraitii wraitii force-pushed the fix/nodestate_bad_proof branch from 58c1bc7 to c1d99ad Compare January 21, 2025 11:31
@wraitii wraitii enabled auto-merge (squash) January 21, 2025 16:25
@wraitii wraitii force-pushed the fix/nodestate_bad_proof branch from c1d99ad to b553bd1 Compare January 21, 2025 16:25
@wraitii wraitii merged commit a70cd00 into main Jan 21, 2025
11 checks passed
@wraitii wraitii deleted the fix/nodestate_bad_proof branch January 21, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhalex hhalex hhalex approved these changes

@BertrandD BertrandD BertrandD approved these changes

@maxgttph maxgttph maxgttph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wraitii @hhalex @BertrandD @maxgttph