Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change workflow check to reformate package-lock.json #1552

Closed
whitingjr opened this issue Mar 28, 2024 · 1 comment · Fixed by #1554
Closed

Change workflow check to reformate package-lock.json #1552

whitingjr opened this issue Mar 28, 2024 · 1 comment · Fixed by #1554
Assignees
Labels
type/bug Something isn't working

Comments

@whitingjr
Copy link
Collaborator

Describe the bug

Dependabot is producing files that reformat the file that conflicts with the teams style rules.

Version

What is the version of Horreum ?

0.12.0
@johnaohara
Copy link
Member

As mentioned on the PR:

was searching for this issue and came across this comment: npm/json-parse-even-better-errors#3 (comment)

Maybe those people complaining about their package-lock not using ... double-spacing just like their package.json file were just a vocal minority,

our package.json is double spaced

We had a brief discussion about trying;

If we can fix the package-lock.json format produced by dependabot, I don't think we need an action to reformat the package-lock.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants