Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat package-lock.json and package.json to single spacing. #1554

Merged

Conversation

whitingjr
Copy link
Collaborator

Fixes Issue

fixes #1552

Changes proposed

[x] - Change workflow to write the file in the correct format

@whitingjr whitingjr self-assigned this Mar 28, 2024
@whitingjr whitingjr requested a review from stalep March 28, 2024 10:51
@stalep
Copy link
Member

stalep commented Mar 28, 2024

I'm not comfortable merging this without having John looking at it first. Let's put this on hold until he is back.

@johnaohara
Copy link
Member

was searching for this issue and came across this comment: npm/json-parse-even-better-errors#3 (comment)

Maybe those people complaining about their package-lock not using ... double-spacing just like their package.json file were just a vocal minority,

our package.json is double spaced

We had a brief discussion about trying;

@whitingjr
Copy link
Collaborator Author

whitingjr commented Apr 15, 2024

Setting versions too version npm 10 and node 20 unless there are concerns with this. This PR changes the format to single spacing. Also rebased on the latest master to stay aligned.

@whitingjr whitingjr force-pushed the horreum-reformat-package-lock-json branch 2 times, most recently from be59f8d to e9fb0a7 Compare April 15, 2024 12:55
…ead rely on on/pull_requests/paths to identify matching paths. Change prettier configuration to use single space indenting. Updated package-lock.json with new indenting. Added configuration to define node and npm versions.
@whitingjr whitingjr force-pushed the horreum-reformat-package-lock-json branch from e9fb0a7 to e9606c0 Compare April 19, 2024 09:22
@whitingjr
Copy link
Collaborator Author

@johnaohara Both package.json and package-lock.json are re-formatted in this commit.

@whitingjr whitingjr changed the title Changed to reformat package-lock.json when formatting rules violated. Reformat package-lock.json and package.json to single spacing. Apr 19, 2024
@johnaohara
Copy link
Member

@whitingjr this looks great, thanks for fixing this issue

@johnaohara johnaohara merged commit cb3aba0 into Hyperfoil:master Apr 19, 2024
3 checks passed
@whitingjr whitingjr deleted the horreum-reformat-package-lock-json branch April 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change workflow check to reformate package-lock.json
3 participants