-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of deprecated table #2209
Conversation
The only one I'm concerned with is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, especially because it fixes the labelValues/dataset comparison overflow when changing the screen size 😄
@barreiro could you please rebase and fix the conflict as I merged the "Dark theme switch" first? Then it's ready to go imo
20cb57a
to
a4d81ff
Compare
yeah, I noticed that issue while testing and the fix was to simply wrap the table in a
done |
fixes #1369
I replaced the
Table
with aDescriptionList
where appropriate