Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated table #2209

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Conversation

barreiro
Copy link
Collaborator

fixes #1369

I replaced the Table with a DescriptionList where appropriate

@barreiro barreiro requested a review from willr3 December 10, 2024 16:34
@barreiro barreiro self-assigned this Dec 10, 2024
@willr3
Copy link
Collaborator

willr3 commented Dec 11, 2024

The only one I'm concerned with is the About.tsx change to DescriptionList. Have you looked at the before and after at different resolutions and looks ok?

@barreiro
Copy link
Collaborator Author

IMO DescriptionList is a more appropriate component to use in some situations (and does look very good). In About.tsx here is the before and after:

image

image

Copy link
Collaborator

@willr3 willr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, especially because it fixes the labelValues/dataset comparison overflow when changing the screen size 😄

@barreiro could you please rebase and fix the conflict as I merged the "Dark theme switch" first? Then it's ready to go imo

@barreiro
Copy link
Collaborator Author

Looks great to me, especially because it fixes the labelValues/dataset comparison overflow when changing the screen size 😄

yeah, I noticed that issue while testing and the fix was to simply wrap the table in a InnerScrollContainer component.

@barreiro could you please rebase and fix the conflict as I merged the "Dark theme switch" first? Then it's ready to go imo

done

@lampajr lampajr merged commit 35c65fc into Hyperfoil:master Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove UI dependencies on @patternfly/react-table/deprecated
3 participants