[WIP] Add iTunes plugin #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still using the same styles from Spotify - For the moment this only marks if iTunes is running or not
- Yet this script isn't implemented inside itunes-node-applescript, i'll do a PR to get it updated and tell the owner to update the npm package
|
By the way, just finished most the functionality, will wait for you to give me some advice with the design part (icon and colors you want to leave there) and this PR to be closed: https://github.com/buley/itunes-node-applescript/pull/1/files |
|
@rodrijuarez I will clone your build tomorrow onto my MBP and test this out, then come back and provide feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you consider the idea of adding iTunes also to the list of music players? For now I just built something to show if it's running or not, but I see that it's something really easy to implement given that I can just copy most of the code already used in the Spotify one