-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Try to) Fix HyperLine on Hyper 2 #161
base: master
Are you sure you want to change the base?
Conversation
Just try it with Hyper 2.1.0-canary.2 on Ubuntu 18.04, not working :( |
Used your pull request as boilerplate and added the code I mentioned in #163 Hyper@latest (canary) |
@liloow can you upload that to a fork? |
@jpmckearin Sorry I was on vacation last week : fork EDIT: Added custom dist (sorry for my oversight 😁) and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested, work on Mint 18 with Hyper 2.1.0-canary.2
@NTag thanks! 🎉 🎉
Tested again Hyper 2.1.0-canary.2 on Ubuntu 18.04 with https://github.com/liloow/hyperline and works perfect, thank you. |
Any ideas on when this will be merged in? Currently, Hyperline is unusable on Hyper 2.1.0 on MacOS because of these deprecations. |
Is there any plan to merge this? |
Had to delete |
Try to make HyperLine work on Hyper 2 (cf. #159 and #160):
hyper/component
is deprecated, useReact.Component
instead;prop-types
fromdevDependencies
(already present independencies
).Works with Hyper 2.1.0-canary.2 on macOS 10.13.