Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Try to) Fix HyperLine on Hyper 2 #161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

NTag
Copy link

@NTag NTag commented Jun 17, 2018

Try to make HyperLine work on Hyper 2 (cf. #159 and #160):

  • React is now bundled as a dependency, as it should be;
  • Using hyper/component is deprecated, use React.Component instead;
  • Remove prop-types from devDependencies (already present in dependencies).

Works with Hyper 2.1.0-canary.2 on macOS 10.13.

@lexdevelop
Copy link

Just try it with Hyper 2.1.0-canary.2 on Ubuntu 18.04, not working :(

@liloow
Copy link

liloow commented Aug 4, 2018

Used your pull request as boilerplate and added the code I mentioned in #163

Hyper@latest (canary)
Arch

Never had any issues
screencap

@jpmckearin
Copy link

@liloow can you upload that to a fork?

@liloow
Copy link

liloow commented Aug 13, 2018

@jpmckearin Sorry I was on vacation last week : fork
Tested on Arch

EDIT: Added custom dist (sorry for my oversight 😁) and custom branch with that ugly global.onload properly coded and a couple other details (this means core file have been modified hence the new branch)

Copy link

@thiamsantos thiamsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, work on Mint 18 with Hyper 2.1.0-canary.2

@NTag thanks! 🎉 🎉

@lexdevelop
Copy link

Tested again Hyper 2.1.0-canary.2 on Ubuntu 18.04 with https://github.com/liloow/hyperline and works perfect, thank you.

@charles4221
Copy link

Any ideas on when this will be merged in? Currently, Hyperline is unusable on Hyper 2.1.0 on MacOS because of these deprecations.

@Sly777
Copy link

Sly777 commented Dec 22, 2018

Is there any plan to merge this?

@talentlessguy
Copy link

Had to delete hyperline bcoz of annoying deprecation messages. Please merge it someone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants