Bump required pytest version to 4.6 #2865
Conversation
|
I'm having some trouble with |
| deps = | ||
| -r../requirements/test.txt | ||
| commands= | ||
| pip install pytest==4.3 pytest-xdist==1.25 pytest-forked==0.2 | ||
| pip install pytest==4.6 pytest-xdist==1.34 |
There was a problem hiding this comment.
I bumped pytest-xdist to the latest version that supports pytest 4.x.
Not sure if pytest-forked still needs to be pinned; pytest-xdist 1.34 seems to work fine with the latest release.
| You are using pytest version %s. Hypothesis tests work with any test | ||
| runner, but our pytest plugin requires pytest 4.6 or newer. | ||
| Note that the pytest developers no longer support your version either! |
There was a problem hiding this comment.
Since I was already updating this message, I took the liberty of making some small editorial tweaks.
|
I assume the test failure has some relation to #2743, since that's when the test was added. |
|
OK, after some investigation it looks like #2743 never actually worked on non-recent versions of pytest. I'm going to bisect to find a reasonable minimum version for the offending test, and not worry too much about it being broken on earlier versions than that, since we already accepted it being broken for <4.6. |
|
The new cutoff for that test is pytest <5.4.0, since that's when it seems to magically start working. |
There was a problem hiding this comment.
Looks good to me, with a few tweaks to the release notes:
- behaviour change = minor release, not patch
- mention that 4.6 is the oldest version of pytest still accepting bugfixes
- I'd use command-line arguments such as --hypothesis-show-statistics rather than the database thing, as a user-visible feature. Current text is fine too.
Happy for you to merge this when ready 😁
|
I don't think I can merge this myself, since it's waiting for “check-pytest43” which will never report completion (as it's been renamed by this change). |
|
Ah, of course - I've updated the required statuses now 😁 |
Motivated by #2863, but also a fine idea in general since 4.6 is the earliest version semi-supported by the pytest maintainers.