-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MultipleFailures
with ExceptionGroup
on Python 3.11+
#3191
Conversation
c5512fc
to
d8e9868
Compare
d8e9868
to
0a4e2ae
Compare
Another future thing: (implemented in #3232) |
Per python/peps#2203, we should be using hypothesis/hypothesis-python/src/hypothesis/core.py Lines 488 to 501 in 09e5035
See also pytest-dev/pytest#9680 - a coherent ecosystem approach to this would be nice. |
The new (once a few questions are resolved around handling in Pytest, and how we print things like falsifying examples before PEP-678 |
Since we now have both an |
Closes #3175, related to #2192 (comment).
Example outputs on Python 3.9.8 and 3.11.0a3
Running
pytest test.py
prints, for respectively Python 3.9.8 and 3.11.0a3:So use of the new
__note__
approach does change the relative order of traceback and other information, but I don't think that's a big deal - we can reverse our own printing for consistency if it's important, because there are clear upstream reasons to display the__note__
in relation to the exception object rather than the traceback.I'm ambivalent about using
__note__
for singular errors, but if we want to that's left for future work in order to keep this diff small.