Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ultica] Sprites for boxes #2527

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[Ultica] Sprites for boxes #2527

merged 2 commits into from
Sep 25, 2024

Conversation

GuakeTheAcinid
Copy link
Contributor

Summary

Added sprites for different types of boxes

Content of the change

item sprites:

  • tiny wooden box
  • small wooden box
  • small plastic box
  • compact wooden box
  • medium wooden box
  • large woodern box
  • oversize wooden box
  • military black box

human_body wielded overlay sprites:

  • medium wooden box
  • medium metal box
  • small wooden box
  • small metal box
  • small plastic box
  • military black box

Testing

testToShowEverythingIsAlright

Additional information

@GuakeTheAcinid GuakeTheAcinid changed the title Added sprites for different types of boxes [Ultica] Sprites for boxes Sep 18, 2024
Fris0uman
Fris0uman requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Fris0uman Fris0uman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fix needed:

  • Remove the unecessary json
  • don't put your name on folders, name them something sensible like here overlay_wielded_balc_box and black_box for exemple

...imateCataclysm/pngs_human_body_32x36/overlay/wielded/by_Guake/overlay_wielded_black_box.json Outdated Show resolved Hide resolved
gfx/UltimateCataclysm/pngs_human_body_32x36/overlay/wielded/containers/overlay_wielded_box.json Outdated Show resolved Hide resolved
gfx/UltimateCataclysm/pngs_human_body_32x36/overlay/wielded/containers/overlay_wielded_box.json Outdated Show resolved Hide resolved
gfx/UltimateCataclysm/pngs_normal_32x32/items/containers/box_wood.json Outdated Show resolved Hide resolved
gfx/UltimateCataclysm/pngs_small_20x20/items/containers/box_small_plastic.json Outdated Show resolved Hide resolved
gfx/UltimateCataclysm/pngs_small_20x20/items/containers/box_wood.json Outdated Show resolved Hide resolved
@GuakeTheAcinid
Copy link
Contributor Author

@Fris0uman, fixes are made.

@Fris0uman Fris0uman merged commit 87521ef into I-am-Erk:master Sep 25, 2024
3 checks passed
@GuakeTheAcinid GuakeTheAcinid deleted the box-tiles branch September 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fris0uman Fris0uman Fris0uman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuakeTheAcinid @Fris0uman