-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#37, #67] add missing docs, remove deprecated taxonomy references #69
Conversation
Decided to break these into two tickets because the taxonomy changes got pretty bloated. Additional updates required by #37 will go into their own PR. |
@ThomasLaPiana Sorry this is unfortunately large 😬 just grabbing all the remaining taxonomy changes added up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a single note, but overall this is an amazing PR @conceptualshark 🦾
the merge conflict should be pretty simple, we've added the new |
@ThomasLaPiana I believe that should be all set now - thanks for digging through all this! 👍 I think because of the way fideslang is set up, you may need to perform the merge. |
@conceptualshark oh it wants a review from you but I don't think it accepts a review from the PR author 😆 Merging! |
Closes #37, #67
Code Changes
identifiable
,nonidentifiable
,derived
, andprovided
subcategories from:Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md