Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#37, #67] add missing docs, remove deprecated taxonomy references #69

Merged
merged 9 commits into from
Aug 12, 2022

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Aug 10, 2022

Closes #37, #67

Code Changes

  • ported over the remaining fideslang docs from fidesctl with new updates
  • Removed all remaining usages of identifiable, nonidentifiable, derived, and provided subcategories from:
    • the documentation files
    • the YAML, json, and resource files
  • updated the .csvs building the visual taxonomy
  • updated the visual taxonomy js to remove deprecated labels
  • updated tests to use examples of the new taxonomy

Steps to Confirm

  • docs build succeeds and finds no instances of the deprecated terms
  • visual taxonomy is viewable with the new hierarchy
  • tests succeed

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@conceptualshark
Copy link
Contributor Author

Decided to break these into two tickets because the taxonomy changes got pretty bloated. Additional updates required by #37 will go into their own PR.

@conceptualshark conceptualshark marked this pull request as ready for review August 11, 2022 13:08
@conceptualshark conceptualshark requested review from a team and ThomasLaPiana August 11, 2022 13:08
@conceptualshark
Copy link
Contributor Author

@ThomasLaPiana Sorry this is unfortunately large 😬 just grabbing all the remaining taxonomy changes added up

Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a single note, but overall this is an amazing PR @conceptualshark 🦾

@ThomasLaPiana
Copy link
Contributor

the merge conflict should be pretty simple, we've added the new is_default field which is why it is conflicting but the deletion should remain I believe

@conceptualshark
Copy link
Contributor Author

@ThomasLaPiana I believe that should be all set now - thanks for digging through all this! 👍 I think because of the way fideslang is set up, you may need to perform the merge.

CHANGELOG.md Outdated Show resolved Hide resolved
@ThomasLaPiana
Copy link
Contributor

@conceptualshark oh it wants a review from you but I don't think it accepts a review from the PR author 😆

Merging!

@ThomasLaPiana ThomasLaPiana merged commit a1dd092 into main Aug 12, 2022
@ThomasLaPiana ThomasLaPiana deleted the 37-update-fideslang-documentation branch August 12, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fideslang documentation
2 participants