Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preprocess taking too long #652

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

ShiromiyaG
Copy link
Member

Description

In the previous code, preprocess was taking too long because it had to read all the files twice

Motivation and Context

How has this been tested?

Doing the preprocess part

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@blaisewf
Copy link
Member

is ready to merge?

@ShiromiyaG
Copy link
Member Author

Yes, I think so

@blaisewf blaisewf merged commit b928451 into IAHispano:main Aug 30, 2024
@ShiromiyaG ShiromiyaG deleted the fix-preprocess branch September 6, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants