Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring for pipeline and training #712

Merged
merged 4 commits into from
Sep 19, 2024
Merged

refactoring for pipeline and training #712

merged 4 commits into from
Sep 19, 2024

Conversation

AznamirWoW
Copy link
Contributor

  1. removed two non-pitch guidance functions from data_utils
  2. using the same audio loader and collate functions regardless of pitch guidance
  3. added proper device handling instead of a command line parameter
  4. removed most of pitch guidance code branching, now net_g gets None values for pitch and pitchf
  5. removed 2 copy-pasted calls for extact_model
  6. streamlined the pipeline logic

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AznamirWoW
1) removed two non-pitch guidance functions from data_utils
ece72ee 
2) using the same audio loader and collate functions regardless of pitch guidance
3) added proper device handling intead of parameter
4) removed most of pitch guidance code branching, now net_g gets None values for pitch and pitchf
5) removed 2 copy-pasted calls for extact_model
6) streamlined the pipeline logic
@AznamirWoW
added missing ) for the log output
5db5e53
@AznamirWoW
fixed exception due to indefined pitchff with pitch_guidance = False …
825e244 
…branch
blaisewf
blaisewf reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@blaisewf blaisewf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI part forcing CPU training needs to be removed, also from the core.py etc.

@blaisewf blaisewf merged commit 17180b2 into IAHispano:main Sep 19, 2024
@AznamirWoW AznamirWoW deleted the refactor1 branch September 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaisewf blaisewf blaisewf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AznamirWoW @blaisewf