Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[untested] Add gpt-4o support (o200k_base) #35

Closed
wants to merge 1 commit into from

Conversation

marckohlbrugge
Copy link

@marckohlbrugge marckohlbrugge commented May 15, 2024

GPT-4o uses o200k_base which this gem currently does not support.

I tried adding it by looking at the Python library. I have NOT tested this code. I'm unfamiliar with Rust and wasn't able to compile it.

Just putting this PR out here to hopefully get the ball rolling on supporting this.

@ScotterC
Copy link
Collaborator

ScotterC commented May 15, 2024

I can get CI running but sadly also unfamiliar with Rust. I'm seeing "cannot find function o200k_base in crate tiktoken_rs" which makes me think a compilation of the rust code needs to be included.

@IAPark would know quickly

@IAPark
Copy link
Owner

IAPark commented May 15, 2024

I think the upstream library needs updated. I'll look into it tomorrow morning

@IAPark
Copy link
Owner

IAPark commented May 16, 2024

Looks like @CaffeeLake beat me to it, closing this now that their PR is merged

@IAPark IAPark closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants