Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SectorVocabulary.xml #341

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Update SectorVocabulary.xml #341

merged 4 commits into from
Feb 23, 2021

Conversation

andreaszenasidi
Copy link
Contributor

Changes made to sector vocabulary XML as requested in:
#336
#338

Copy link
Contributor

@nosvalds nosvalds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One small comment/update.

xml/SectorVocabulary.xml Outdated Show resolved Hide resolved
xml/SectorVocabulary.xml Outdated Show resolved Hide resolved
xml/SectorVocabulary.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@amy-silcock amy-silcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me!

@nosvalds
Copy link
Contributor

I'm merging this now. I'm not going to go through the whole process to generate the Website pages and push them there right now as it's quite a bit of overhead. These will be included the next time we do an update of the website SSOT pages.

@nosvalds nosvalds merged commit 0f46f17 into master Feb 23, 2021
@nosvalds nosvalds deleted the sector-vocabulary-update branch February 23, 2021 09:17
@andylolz
Copy link
Contributor

I'm not going to go through the whole process to generate the Website pages and push them there right now as it's quite a bit of overhead. These will be included the next time we do an update of the website SSOT pages.

It would be cool to auto-deploy via a github action.

It was discussed for the old reference site in IATI/IATI-Standard-SSOT#164 and IATI/IATI-Standard-SSOT#297. In fact it was implemented here: https://referencebot.github.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants