Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

This allows spaces in CF_ORG and CF_SPACE #65

Merged
merged 1 commit into from
Nov 6, 2017
Merged

This allows spaces in CF_ORG and CF_SPACE #65

merged 1 commit into from
Nov 6, 2017

Conversation

sdague
Copy link
Contributor

@sdague sdague commented Nov 1, 2017

The pipeline-DEPLOY.sh script was optimistic about assumptions in the
CF variables, and didn't take into account ones that might have
spaces. This fixes a few of the issues uncovered by bug #54.

The pipeline-DEPLOY.sh script was optimistic about assumptions in the
CF variables, and didn't take into account ones that might have
spaces. This fixes a few of the issues uncovered by bug #54.
@l2fprod l2fprod self-assigned this Nov 6, 2017
@l2fprod l2fprod changed the base branch from master to test November 6, 2017 16:43
@l2fprod l2fprod merged commit 995c7e2 into IBM-Cloud:test Nov 6, 2017
@l2fprod
Copy link
Member

l2fprod commented Nov 6, 2017

@sdague I merged this to the test branch but I'm still getting an issue with the Speech to Text callback:

Speech to Text OpenWhisk action is accessible at https://openwhisk.ng.bluemix.net/api/v1/web/myemail@ibm.com_space+with+spaces/vision/speechtotext
....
No local.env found. Dark Vision configuration will be loaded from environment variables.
Registering Speech to Text callback...
{"code":400,"code_description":"Bad Request","error":"unable to register callback url 'https://openwhisk.ng.bluemix.net/api/v1/web/myemail@ibm.com_space with spaces/vision/speechtotext', callback server responded with status code 505"}
Done

I reported an issue to the Speech to Text service which does not correctly handle spaces in URL. Seems this issue is still there. The Cloud Functions piece is working.

Did STT work for you?

@sdague
Copy link
Contributor Author

sdague commented Nov 6, 2017

You are right, this appears to be a bug in the Speech to Text service. I built a custom callback using a simple PHP script, and the moment I put spaces in the url encoded with either %20 or + they fail. You have a link to that bug? This would be a good thing to figure out why they don't support that.

@l2fprod
Copy link
Member

l2fprod commented Nov 7, 2017

thanks. I merged the fix for Cloud Functions in master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants