Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: added DH group 19 and sha 512 support for TFP #2361

Merged

Conversation

ujjwal-ibm
Copy link
Collaborator

added DH group 19 and sha512 changes for ike policy and ipsec policy as per the SDK changes

@hkantare
Copy link
Collaborator

Hi @ujjwal-ibm
As part of this PR

func validateKeyLifeTime(v interface{}, k string) (ws []string, errors []error) {

Can you change the min value as per this doc
https://test.cloud.ibm.com/apidocs/vpc#create-ike-policy

@ujjwal-ibm ujjwal-ibm force-pushed the enhancement-DHGroup19Sha512Support branch from 416f38f to b7c445c Compare March 17, 2021 06:30
@ujjwal-ibm ujjwal-ibm force-pushed the enhancement-DHGroup19Sha512Support branch from b7c445c to a4361a9 Compare March 17, 2021 08:20
@hkantare hkantare merged commit ebffedd into IBM-Cloud:master Mar 17, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants