Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for range of ports for NLB vnf #3207

Merged
merged 1 commit into from
Oct 27, 2021
Merged

added support for range of ports for NLB vnf #3207

merged 1 commit into from
Oct 27, 2021

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Oct 14, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMISNLBRouteModeListener_basic
--- PASS: TestAccIBMISNLBRouteModeListener_basic (730.28s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 734.523s

=== RUN   TestAccIBMISLBListener_basic
--- PASS: TestAccIBMISLBListener_basic (713.72s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 717.230s

hkantare
hkantare reviewed Oct 21, 2021
View reviewed changes
ibm/resource_ibm_is_lb_listener.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_lb_listener.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_lb_listener.go Show resolved Hide resolved
@uibm
Copy link
Collaborator Author

uibm commented Oct 26, 2021

@geethasathyamurthy Please review the document change in this PR.

@uibm uibm force-pushed the nlb-port-range branch 2 times, most recently from 9f4e246 to 98778fa Compare October 26, 2021 11:02
geethasathyamurthy
geethasathyamurthy reviewed Oct 26, 2021
View reviewed changes
Copy link
Contributor

@geethasathyamurthy geethasathyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, need a few edits in the docs to approve.

@hkantare hkantare merged commit ffe4970 into IBM-Cloud:master Oct 27, 2021
@astha-jain astha-jain mentioned this pull request Nov 10, 2021
Closed
@uibm uibm deleted the nlb-port-range branch December 1, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

@kavya498 kavya498 kavya498 left review comments

@geethasathyamurthy geethasathyamurthy geethasathyamurthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uibm @hkantare @geethasathyamurthy @kavya498