Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(is_instance) : added logic to set port speed in primary nic of instance datasource and resource #3367

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix(is_instance) : added logic to set port speed in primary nic of instance datasource and resource #3367

merged 1 commit into from
Apr 11, 2022

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Nov 26, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

--- PASS: TestAccIBMISInstanceDataSource_basic (266.54s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm	270.331s

--- PASS: TestAccIBMISInstance_basic (202.88s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm	206.741s

--- PASS: TestAccIBMISInstance_action (465.04s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm	469.933s

--- PASS: TestAccIBMISFloatingIPDataSource_basic (468.64s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 472.872s

@uibm uibm force-pushed the ins-nic-portspeed branch 3 times, most recently from 43f9e3d to 7eb35d6 Compare December 6, 2021 08:10
@uibm uibm marked this pull request as draft January 6, 2022 11:28
@uibm uibm marked this pull request as ready for review January 18, 2022 14:43
@uibm uibm force-pushed the ins-nic-portspeed branch from 9ac6edf to 6a84371 Compare January 20, 2022 07:46
@uibm uibm changed the title added logic to set port speed in primary nic of instance datasource and resource fix(is_instance) : added logic to set port speed in primary nic of instance datasource and resource Jan 20, 2022
@uibm uibm force-pushed the ins-nic-portspeed branch from 2988381 to a63a086 Compare February 17, 2022 06:17
@uibm uibm force-pushed the ins-nic-portspeed branch from f010cc5 to 2ba8c66 Compare March 15, 2022 06:59
@uibm uibm force-pushed the ins-nic-portspeed branch from 2ba8c66 to 50770a5 Compare April 7, 2022 06:26
@uibm uibm force-pushed the ins-nic-portspeed branch from 8cad7d6 to bf537be Compare April 7, 2022 09:39
@hkantare hkantare merged commit 5acf57f into IBM-Cloud:master Apr 11, 2022
@uibm uibm deleted the ins-nic-portspeed branch April 14, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uibm @hkantare