Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(changed): changed list logic in datasource by name #3415

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Dec 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

--- PASS: TestAccIBMIsFlowLogDataSourceBasic (186.73s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 190.093s
--- PASS: TestAccIBMISImageDataSource_basic (16.88s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 20.582s
--- PASS: TestAccIBMISInstanceDataSource_basic (255.15s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 258.555s
--- PASS: TestAccIBMISSnapshotDatasource_basic (283.86s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 287.361s
--- PASS: TestAccIBMISVirtualEndpointGatewayDataSource_basic (106.61s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 109.462s
--- PASS: TestAccIBMISVolumeDatasource_basic (87.11s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 90.943s

@hkantare
Copy link
Collaborator

Can you please share the result of testcases

@uibm uibm force-pushed the datasource-replace-listbyname branch from ee61761 to 1dc2c29 Compare January 10, 2022 06:51
@hkantare
Copy link
Collaborator

hkantare commented Apr 7, 2022

Please conflicts in the files

@uibm uibm force-pushed the datasource-replace-listbyname branch from 9752252 to b7e7996 Compare April 13, 2022 05:58
@hkantare hkantare merged commit 7a4de74 into IBM-Cloud:master Apr 14, 2022
@uibm uibm deleted the datasource-replace-listbyname branch April 14, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants