Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(is_region): made name as optional in ibm_is_region datasource #3431

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

ujjwal-ibm
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #1258

Output from acceptance testing:

--- PASS: TestAccIBMISRegionDataSource_basic (35.59s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 40.186s

@ujjwal-ibm ujjwal-ibm force-pushed the is-region-datasource-name branch 2 times, most recently from a46339e to a458962 Compare December 14, 2021 08:15
@ujjwal-ibm
Copy link
Collaborator Author

rebased

=== RUN   TestAccIBMISRegionDataSource_basic
--- PASS: TestAccIBMISRegionDataSource_basic (29.89s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     31.770s

@ujjwal-ibm
Copy link
Collaborator Author

rebased

--- PASS: TestAccIBMISRegionDataSource_basic (22.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     24.871s

@hkantare hkantare merged commit 70ad264 into IBM-Cloud:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibm_is_region make name optional
2 participants